Java now uses struct_tag types (2nd edition) #3530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allredj
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
martin-cs,
NathanJPhillips,
peterschrammel,
pkesseli,
romainbrenguier,
smowton,
tautschnig and
thk123
as code owners
|
TG bump is here: https://github.com/diffblue/test-gen/pull/2384 |
| @@ -164,7 +164,7 @@ bool is_multidim_java_array_type(const typet &type) | |||
| { | |||
| return is_java_array_type(type) && | |||
| is_java_array_type( | |||
| java_array_element_type(to_symbol_type(type.subtype()))); | |||
There was a problem hiding this comment.
clang-format nitpick: https://travis-ci.org/diffblue/cbmc/jobs/463928375#L538
There was a problem hiding this comment.
@peterschrammel fixed
allredj
force-pushed
the
java-struct-tag2
branch
from
371ad5f to
0b2d3b1
Compare
allredj
commented
Dec 6, 2018
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 0b2d3b1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93796858
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
kroening
approved these changes
Dec 6, 2018
peterschrammel
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #3102 with the following changes:
interpretert::get_size()(last commit)